Skip to content

chore: Consume from the ToastMessageContext #36478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 2 commits into from
Jul 23, 2025
Merged

chore: Consume from the ToastMessageContext #36478

kodiakhq merged 2 commits into from
Jul 23, 2025

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jul 20, 2025 •
edited by atlassian bot
Loading

Proposed changes (including videos or screenshots)

Issue(s)

ARCH-1723

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 20, 2025 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.10.0, but it targets 7.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: ceb417f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2025 •
edited
Loading

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36478/

Built to branch gh-pages at 2025-07-23 13:27 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.70%. Comparing base (91fb559) to head (ceb417f).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36478      +/-   ##
===========================================
+ Coverage    65.67%   65.70%   +0.02%     
===========================================
  Files         3174     3174              
  Lines       105846   105831      -15     
  Branches     20109    20069      -40     
===========================================
+ Hits         69518    69532      +14     
+ Misses       33657    33626      -31     
- Partials      2671     2673       +2
Flag Coverage Δ
e2e 58.13% <85.71%> (+0.04%) ⬆️
unit 70.82% <71.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan tassoevan marked this pull request as ready for review July 20, 2025 23:29
@tassoevan tassoevan requested review from a team as code owners July 20, 2025 23:29
@tassoevan tassoevan added this to the 7.9.0 milestone Jul 20, 2025
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jul 21, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 21, 2025
@MartinSchoeler MartinSchoeler modified the milestones: 7.9.0, 7.10.0 Jul 23, 2025
@kodiakhq kodiakhq bot merged commit 71bfd07 into develop Jul 23, 2025
71 of 73 checks passed
@kodiakhq kodiakhq bot deleted the chore/use-toast-message-dispatch branch July 23, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinSchoeler MartinSchoeler MartinSchoeler approved these changes

@dougfabris dougfabris dougfabris approved these changes

@gabriellsh gabriellsh gabriellsh approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@tassoevan @MartinSchoeler @dougfabris @gabriellsh